Vergleich online.php - 1.8.5 - 1.8.33

$templatelist = "online,online_row,online_row_ip,online_today,online_today_row,online_row_ip_lookup,multipage,multipage_end,multipage_jump_page,multipage_nextpage,multipage_page,multipage_page_current,multipage_page_link_current,multipage_prevpage,multipage_start";

$templatelist = "online,online_row,online_row_ip,online_today,online_today_row,online_row_ip_lookup,online_refresh,multipage,multipage_end,multipage_start";
$templatelist .= ",multipage_jump_page,multipage_nextpage,multipage_page,multipage_page_current,multipage_page_link_current,multipage_prevpage";

	if(!$mybb->settings['threadsperpage'] || (int)$mybb->settings['threadsperpage'] < 1)
	{
		$mybb->settings['threadsperpage'] = 20;
	}
	

	if(!$mybb->settings['wolusersperpage'] || (int)$mybb->settings['wolusersperpage'] < 1)
	{
		$mybb->settings['wolusersperpage'] = 20;
	}

	$perpage = $mybb->settings['threadsperpage'];

	$perpage = $mybb->settings['wolusersperpage'];

		if($page > $pages)
		{
			$start = 0;
			$page = 1;
		}
	}

		if($page > $pages)
		{
			$start = 0;
			$page = 1;
		}
	}

		if($online['invisible'] == 1)

		if($online['invisible'] == 1 && $mybb->usergroup['canbeinvisible'] == 1)

			$username = $online['username'];
			$username = format_name($username, $online['usergroup'], $online['displaygroup']);

			$username = format_name(htmlspecialchars_uni($online['username']), $online['usergroup'], $online['displaygroup']);

			$onlinetime = my_date($mybb->settings['timeformat'], $online['lastactive']);

			$onlinetime = my_date('normal', $online['lastactive']);

	{

	{

	}

	}

	$multipage = multipage($todaycount, $perpage, $page, "online.php?action=today");

	}

	}

				$sql = "s.time DESC";

				$sql = "CASE WHEN s.uid > 0 THEN 1 ELSE 0 END DESC, s.time DESC";

	// Exactly how many users are currently online?
	switch($db->type)
	{
		case "sqlite":
			$sessions = array();
			$query = $db->simple_select("sessions", "sid", "time > {$timesearch}");
			while($sid = $db->fetch_field($query, "sid"))
			{
				$sessions[$sid] = 1;
			}
			$online_count = count($sessions);
			unset($sessions);
			break;
		case "pgsql":
		default:
			$query = $db->simple_select("sessions", "COUNT(sid) as online", "time > {$timesearch}");
			$online_count = $db->fetch_field($query, "online");
			break;
	}
	

	$query = $db->query("
		SELECT COUNT(*) AS online FROM (
			SELECT 1
			FROM " . TABLE_PREFIX . "sessions
			WHERE time > $timesearch
			GROUP BY uid, ip
		) s
	");

	$online_count = $db->fetch_field($query, "online");

	$query = $db->query("
		SELECT DISTINCT s.sid, s.ip, s.uid, s.time, s.location, u.username, s.nopermission, u.invisible, u.usergroup, u.displaygroup
		FROM ".TABLE_PREFIX."sessions s
		LEFT JOIN ".TABLE_PREFIX."users u ON (s.uid=u.uid)
		WHERE s.time>'$timesearch'
		ORDER BY $sql
		LIMIT {$start}, {$perpage}
	");

	$dbversion = $db->get_version();
	if(
		(
			$db->type == 'mysqli' && (
				version_compare($dbversion, '10.2.0', '>=') || ( // MariaDB
					version_compare($dbversion, '10', '<') &&
					version_compare($dbversion, '8.0.2', '>=')
				)
			)
		) ||
		($db->type == 'pgsql' && version_compare($dbversion, '8.4.0', '>=')) ||
		($db->type == 'sqlite' && version_compare($dbversion, '3.25.0', '>='))
	)
	{
		$sql = str_replace('u.username', 's.username', $sql);

		$query = $db->query("
			SELECT * FROM (
				SELECT
					s.sid, s.ip, s.uid, s.time, s.location, u.username, s.nopermission, u.invisible, u.usergroup, u.displaygroup,
					row_number() OVER (PARTITION BY s.uid, s.ip ORDER BY time DESC) AS row_num
				FROM
					".TABLE_PREFIX."sessions s
					LEFT JOIN ".TABLE_PREFIX."users u ON (s.uid = u.uid)
				WHERE s.time > $timesearch
			) s
			WHERE row_num = 1
			ORDER BY $sql
			LIMIT {$start}, {$perpage}
		");
	}
	else
	{
		$query = $db->query("
			SELECT
				s.sid, s.ip, s.uid, s.time, s.location, u.username, s.nopermission, u.invisible, u.usergroup, u.displaygroup
			FROM
				".TABLE_PREFIX."sessions s
				INNER JOIN (
					SELECT
						MIN(s2.sid) AS sid
					FROM
						".TABLE_PREFIX."sessions s2
						LEFT JOIN ".TABLE_PREFIX."sessions s3 ON (s2.sid = s3.sid AND s2.time < s3.time)
					WHERE s2.time > $timesearch AND s3.sid IS NULL
					GROUP BY s2.uid, s2.ip
				) s2 ON (s.sid = s2.sid)
				LEFT JOIN ".TABLE_PREFIX."users u ON (s.uid = u.uid)
			ORDER BY $sql
			LIMIT {$start}, {$perpage}
		");
	}

		$refresh = "<meta http-equiv=\"refresh\" content=\"{$refresh_time};URL=online.php{$refresh_string}\" />";

		eval("\$refresh = \"".$templates->get("online_refresh")."\";");