Vergleich inc/functions_upload.php - 1.8.9 - 1.8.24

	if($attachment === false)
	{
		// no attachment found with the given details
		return;
	}

	}

	// check the length of the filename
	$maxFileNameLength = 255;
	if(my_strlen($attachment['name']) > $maxFileNameLength)
	{
		$ret['error'] = $lang->sprintf($lang->error_attach_filename_length, htmlspecialchars_uni($attachment['name']), $maxFileNameLength);
		return $ret;

	return $ret;
}

/**
 * Check whether the input $FILE variable indicates a PHP file upload error,
 * and if so, return an appropriate user-friendly error message.
 *
 * @param array $FILE File data (as fed by PHP's $_FILE).
 *
 * @return string Error message or empty if no error detected.
 */
function check_parse_php_upload_err($FILE)
{
	global $lang;

	$err = '';

	if(isset($FILE['error']) && $FILE['error'] != 0 && ($FILE['error'] != UPLOAD_ERR_NO_FILE || $FILE['name']))
	{
		$err = $lang->error_uploadfailed.$lang->error_uploadfailed_detail;
		switch($FILE['error'])
		{
			case 1: // UPLOAD_ERR_INI_SIZE
				$err .= $lang->error_uploadfailed_php1;
				break;
			case 2: // UPLOAD_ERR_FORM_SIZE
				$err .= $lang->error_uploadfailed_php2;
				break;
			case 3: // UPLOAD_ERR_PARTIAL
				$err .= $lang->error_uploadfailed_php3;
				break;
			case 4: // UPLOAD_ERR_NO_FILE
				$err .= $lang->error_uploadfailed_php4;
				break;
			case 6: // UPLOAD_ERR_NO_TMP_DIR
				$err .= $lang->error_uploadfailed_php6;
				break;
			case 7: // UPLOAD_ERR_CANT_WRITE
				$err .= $lang->error_uploadfailed_php7;
				break;
			default:
				$err .= $lang->sprintf($lang->error_uploadfailed_phpx, $FILE['error']);
				break;
		}
	}

	return $err;
}

/**
 * Process adding attachment(s) when the "Add Attachment" button is pressed.
 *
 * @param int $pid The ID of the post.
 * @param array $forumpermission The permissions for the forum.
 * @param string $attachwhere Search string "pid='$pid'" or "posthash='".$db->escape_string($mybb->get_input('posthash'))."'"
 * @param string $action Where called from: "newthread", "newreply", or "editpost"
 *
 * @return array Array of errors if any, empty array otherwise
 */
function add_attachments($pid, $forumpermissions, $attachwhere, $action=false)
{
	global $db, $mybb, $editdraftpid, $lang;

	$ret = array();

	if($forumpermissions['canpostattachments'])
	{
		$attachments = array();
		$fields = array ('name', 'type', 'tmp_name', 'error', 'size');
		$aid = array();

		$total = isset($_FILES['attachments']['name']) ? count($_FILES['attachments']['name']) : 0;
		$filenames = "";
		$delim = "";
		for($i=0; $i<$total; ++$i)
		{
			foreach($fields as $field)
			{
				$attachments[$i][$field] = $_FILES['attachments'][$field][$i];
			}

			$FILE = $attachments[$i];
			if(!empty($FILE['name']) && !empty($FILE['type']) && $FILE['size'] > 0)
			{
				$filenames .= $delim . "'" . $db->escape_string($FILE['name']) . "'";
				$delim = ",";
			}
		}

		if ($filenames != '')
		{
			$query = $db->simple_select("attachments", "filename", "{$attachwhere} AND filename IN (".$filenames.")");

			while ($row = $db->fetch_array($query))
			{
				$aid[$row['filename']] = true;
			}
		}

		foreach($attachments as $FILE)
		{
			if($err = check_parse_php_upload_err($FILE))
			{
				$ret['errors'][] = $err;
				$mybb->input['action'] = $action;
			}
			else if(!empty($FILE['name']) && !empty($FILE['type']))
			{
				if($FILE['size'] > 0)
				{
					$filename = $db->escape_string($FILE['name']);
					$exists = $aid[$filename];

					$update_attachment = false;
					if($action == "editpost")
					{
						if($exists && $mybb->get_input('updateattachment') && ($mybb->usergroup['caneditattachments'] || $forumpermissions['caneditattachments']))
						{
							$update_attachment = true;
						}
					}
					else
					{
						if($exists && $mybb->get_input('updateattachment'))
						{
							$update_attachment = true;
						}
					}

					$attachedfile = upload_attachment($FILE, $update_attachment);

					if(!empty($attachedfile['error']))
					{
						$ret['errors'][] = $attachedfile['error'];
						$mybb->input['action'] = $action;
					}

				}
				else
				{
					$ret['errors'][] = $lang->sprintf($lang->error_uploadempty, htmlspecialchars_uni($FILE['name']));
					$mybb->input['action'] = $action;
				}
			}
		}
	}